Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why removed reverberation? #7

Open
girtabb opened this issue Aug 25, 2023 · 13 comments
Open

Why removed reverberation? #7

girtabb opened this issue Aug 25, 2023 · 13 comments

Comments

@girtabb
Copy link

girtabb commented Aug 25, 2023

I'm curious if there's a possibility that larger rooms could also come alongside a version with their original reverberation, like the Small broadcast studio

@ShanonPearce
Copy link
Owner

That shouldn't be a problem. I will include a set of alternative BRIRs without reverberation reductions for the larger rooms.

@girtabb
Copy link
Author

girtabb commented Aug 26, 2023

Thank you! =)

@girtabb girtabb closed this as completed Aug 26, 2023
@NekoAlosama
Copy link

ShanonPearce didn't answer the question though. I'm assuming it's because the reverberation makes the sound bad or unrealistic (e.g. you're listening in a small room, but your BRIR comes from a very large room), but we wouldn't know until ShanonPearce includes it.

@ShanonPearce
Copy link
Owner

The aim of the reverberation reductions was to reduce the amount of distracting late reflections that were present in the larger rooms. As a result there are differences in perceived room size.

I have now added alternative BRIRs without the reverberation reductions for most of the larger rooms so the different versions of the rooms can be compared.

@girtabb
Copy link
Author

girtabb commented Aug 27, 2023

Hey ShanonPearce! Thanks for uploading these versions. However, I'm a little confused. The versions you added do add more reverberation, but, from what I know, there are supposed to be a lot more reflections I believe (refer to the video, where I compare and use a file from the WDR website's original samples, in which sound only comes from one angle I think). Now I'm just curious if there are more things you consciously do to these samples to create these IR files or if this is unexpectedly happening. Correct me if I understand something incorrectly, I'm not much of an expert yet. Also, I screenshotted the wrong folder (LBS instead of SBS), it's just to maybe clear some confusion as to what kind of files I'm talking about, you might be familiar with those

ir.mp4

@ShanonPearce
Copy link
Owner

ShanonPearce commented Aug 27, 2023

I had another look into my script and there is actually still some windowing active that occurs towards the end of the IR, reducing the overall reverberation time. I will leave the new BRIRs as they are though as removing this windowing will cause a larger mismatch in decay time between the higher frequencies and low frequencies (which are integrated from a separate source and have shorter decay time).

To avoid any further confusion I have updated the naming of the 2 sets of BRIRs to have "Reduced_Reverb" and "More_Reverb"

@girtabb
Copy link
Author

girtabb commented Aug 28, 2023

So wait, which one has a shorter decay time? The high or the low end? Aren't differences in decay time what's needed to achieve an even wider feeling sound?

@ShanonPearce
Copy link
Owner

ShanonPearce commented Aug 28, 2023

In most of the original room responses, the higher frequencies have shorter decay times than the low frequencies. The challenge I was facing was achieving a natural decay when integrating generalised low frequency BRIRs into the original BRIRs for low frequency extension. Some of the original BRIRs had decay times much longer than the generalised low frequency BRIRs resulting in unusually long decay times in the higher frequencies relative to low frequencies. There is still some reduction in late reflections in the new BRIRs to avoid this problem.

@girtabb
Copy link
Author

girtabb commented Aug 28, 2023

So if I understand this correctly, you remove some late reflections or apply "windowing" in order to maintain low-frequency extension and relatively similar decay times across the whole frequency response?

@ShanonPearce
Copy link
Owner

Yes the main intent of the late reflection reduction is to ensure the decay times are relatively consistent across the spectrum and not increasing with frequency after low frequency extension. It isn't as much of an issue for smaller rooms as the low frequency extension tends to integrate nicely with the less reverberant rooms.

@girtabb
Copy link
Author

girtabb commented Aug 28, 2023

Yeah, I noticed you didn't add the Large broadcast studio. I assume that'd be too much of a hassle to try to make it consistent across the whole spectrum, right?

@girtabb girtabb reopened this Sep 2, 2023
@ShanonPearce
Copy link
Owner

Yeah, I noticed you didn't add the Large broadcast studio. I assume that'd be too much of a hassle to try to make it consistent across the whole spectrum, right?

Yeah currently it would be difficult to include the Large broadcast studio in this dataset due to its long reverberation times and a lack of data for low frequency extension. I will look into including it in a future release along with versions of the other large rooms having their original reverberation times. I will first need to improve low frequency extension for rooms containing long reverberation times.

@girtabb
Copy link
Author

girtabb commented Sep 4, 2023

Thanks a lot! In the end, there shouldn't be a problem if you just add "experimental" HRIRs that lack things like bass extension, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants