Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve block handling #101

Merged
merged 1 commit into from
May 4, 2022
Merged

Improve block handling #101

merged 1 commit into from
May 4, 2022

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented May 4, 2022 •
edited

Usage related changes

  • Improve typing of Block (use existing starknet-types for its nested properties)

Development related changes

  • Remove property deletion in getBlockUtil.
  • Move BlockIdentifier.
  • Add JSDoc to starknet-types.ts.
  • Fix formatting.

Checklist:

@FabijanC FabijanC requested a review from Nathan-SL May 4, 2022 13:30
@Nathan-SL Nathan-SL merged commit baadad2 into master May 4, 2022
@FabijanC FabijanC deleted the fix-block branch May 4, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nathan-SL Nathan-SL Awaiting requested review from Nathan-SL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FabijanC @Nathan-SL