Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change contract path handling #26

Merged
merged 13 commits into from
Dec 9, 2021

Conversation

dribeiro-ShardLabs
Copy link
Contributor

@dribeiro-ShardLabs dribeiro-ShardLabs commented Dec 7, 2021

Removed the recursive function "traverseFiles" and changed it for "glob"
Added a check for faulty venv
Added support for relative paths for contractFactory

@dribeiro-ShardLabs dribeiro-ShardLabs requested review from FabijanC and a user December 7, 2021 16:04
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also as discussed, Readme should have the paths issue clarified (PATH.cairo).

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@FabijanC FabijanC changed the title Remove recursion traverse files Change contract path handling Dec 8, 2021
@dribeiro-ShardLabs dribeiro-ShardLabs merged commit cd6b2aa into master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants