Using caching in CircleCI to optimize workflow. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabijanC
requested changes
Jan 14, 2022
.circleci/config.yml
Outdated
| - &restore_cairo_cache | ||
| - restore_cache: | ||
| name: "Restore cairo-lang Cache" | ||
| key: cairo-lang-cache-{{ arch }}-{{ checksum "/tmp/cairo-lang-version" }} |
There was a problem hiding this comment.
I've given this some more thought. There's a danger in doing this in case plugin's not yet been adapted to work with the latest version. This is clear if we observe the setup-venv script which has the plugin version hardcoded.
The ideal approach would be to have the current cairo-lang to which the plugin is adapted only in one place, but so far we haven't been able to come up with that.
Probably we'll have to hardcode it here as well. That way we'll have two more places (restore and save) to change when adapting to new cairo-lang versions (there are a few already across the project, e.g. Readme). Or in case we can utilize variables config.yml, there'd only be one more place.
dribeiro-ShardLabs
force-pushed
the
circleci-cache
branch
from
0f86795
to
fe93097
Compare
FabijanC
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized CircleCI workflow to use caching