Account enhancement #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clacladev
reviewed
Feb 23, 2022
FabijanC
requested changes
Feb 24, 2022
src/account.ts
Outdated
| * @param selector function in the contract to be called | ||
| * @param calldata calldata to use as input for the contract call | ||
| */ | ||
| abstract adaptArgs(toAddress: string, selector: string, calldata: StringMap): any; |
There was a problem hiding this comment.
I think adaptArgs doesn't have to be in the abstract class, it's an implementation detail.
Either that, or call/invoke can be template methods already implemented in the abstract class, relying on methods yet to be overriden in child classes (methods like adaptArgs or getExecuteFunction.
dribeiro-ShardLabs
force-pushed
the
account-enhancement
branch
from
ef0a06a
to
c071aec
Compare
FabijanC
requested changes
Feb 24, 2022
FabijanC
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Account class, which serves as a proxy for contract interaction