Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argent account implementation #79

Merged
merged 15 commits into from
Mar 15, 2022

Conversation

dribeiro-ShardLabs
Copy link
Contributor

@dribeiro-ShardLabs dribeiro-ShardLabs commented Mar 14, 2022

Usage related changes

  • Argent Account implementation can now be used:
    • additional functionalities for guardian setting await loadedAccount.setGuardian(account.guardianPrivateKey) ;
    • can be deployed and used the same way as the OpenZeppelin implementation, e.g account = await starknet.deployAccount("ArgentAccount"), but to load from an address or to change the guardian, must import import { ArgentAccount } from "@shardlabs/starknet-hardhat-plugin/dist/account" and cast as ArgentAccount const loadedAccount = (await starknet.getAccountFromAddress(accountAddress, privateKey, "ArgentAccount")) as ArgentAccount
  • Both Argent and OZ implementations now support multicall/invoke, described in README

Development related changes

  • Implemented Argent Account, changed way OZ implementation invokes, now it uses multicall/invoke, without breaking changes

Checklist:

  • I have formatted the code
  • I have performed a self-review of the code
  • I have rebased to the base branch
  • I have documented the changes
  • I have updated the tests
  • I have created a PR to the plugin branch of starknet-hardhat-example.

package-lock.json Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
test/general-tests/account-test/check.sh Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/type-extensions.ts Show resolved Hide resolved
src/account.ts Outdated Show resolved Hide resolved
src/account.ts Outdated Show resolved Hide resolved
src/account.ts Outdated Show resolved Hide resolved
src/account-utils.ts Show resolved Hide resolved
@@ -3,52 +3,64 @@
If you've used Hardhat 👷‍♀️👷‍♂️ and want to develop for Starknet <img src="https://starkware.co/wp-content/uploads/2021/07/Group-177.svg" alt="starknet" width="18"/>, this plugin might come in hand. If you've never set up a Hardhat project, check out [this guide](https://hardhat.org/tutorial/creating-a-new-hardhat-project.html).

## Contents
- [Install](#install)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to config.yml, I see formatting has been applied. I've been avoiding that change as it makes the review difficult. If you could revert the formatting changes, then I'd be able to review more easily.

@dribeiro-ShardLabs dribeiro-ShardLabs merged commit 98a201c into master Mar 15, 2022
@dribeiro-ShardLabs dribeiro-ShardLabs deleted the argent-account-implementation branch March 15, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants