-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argent account implementation #79
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabijanC
requested changes
Mar 15, 2022
@@ -3,52 +3,64 @@ | |||
If you've used Hardhat 👷♀️👷♂️ and want to develop for Starknet <img src="https://starkware.co/wp-content/uploads/2021/07/Group-177.svg" alt="starknet" width="18"/>, this plugin might come in hand. If you've never set up a Hardhat project, check out [this guide](https://hardhat.org/tutorial/creating-a-new-hardhat-project.html). | |||
|
|||
## Contents | |||
- [Install](#install) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to config.yml, I see formatting has been applied. I've been avoiding that change as it makes the review difficult. If you could revert the formatting changes, then I'd be able to review more easily.
FabijanC
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
await loadedAccount.setGuardian(account.guardianPrivateKey)
;account = await starknet.deployAccount("ArgentAccount")
, but to load from an address or to change the guardian, must importimport { ArgentAccount } from "@shardlabs/starknet-hardhat-plugin/dist/account"
and cast as ArgentAccountconst loadedAccount = (await starknet.getAccountFromAddress(accountAddress, privateKey, "ArgentAccount")) as ArgentAccount
Development related changes
Checklist:
plugin
branch ofstarknet-hardhat-example
.