Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to 0.8.0 #80

Merged
merged 15 commits into from
Mar 17, 2022
Merged

Adapt to 0.8.0 #80

merged 15 commits into from
Mar 17, 2022

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Mar 15, 2022 •
edited

Usage related changes

  • Introduce hardhat starknet-estimate-fee.
  • Introduce StarknetContract.estimateFee.
  • Use 0.8.0 docker version by default`.
  • Support hex strings as contract function input.

Development related changes

  • Make Choice more refined:
    • Distinguish between:
      • ExecuteChoice = "invoke" | "call"
      • InteractChoice = ExecuteChoice | estimate_fee
    • Rationale:
      • estimate_fee can reuse a lot of old code

Checklist:

  • I have formatted the code
  • I have performed a self-review of the code
  • I have rebased to the base branch
  • I have documented the changes
  • I have updated the tests
  • I have created a PR to the plugin branch of starknet-hardhat-example.

dribeiro-ShardLabs
dribeiro-ShardLabs reviewed Mar 16, 2022
View reviewed changes
src/adapt.ts Outdated Show resolved Hide resolved
@FabijanC FabijanC merged commit 9d6f2d3 into master Mar 17, 2022
@FabijanC FabijanC deleted the adapt-0.8.0 branch March 17, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dribeiro-ShardLabs dribeiro-ShardLabs dribeiro-ShardLabs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FabijanC @dribeiro-ShardLabs