Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke options #84

Merged
merged 12 commits into from
Mar 28, 2022
Merged

Invoke options #84

merged 12 commits into from
Mar 28, 2022

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Mar 28, 2022

Usage related changes

  • Allow specifying maxFee and nonce.
  • Introduce --account-contract flag for compiling account contracts.
    • Account contracts are currently those with a function called __execute__, hence the addition of such a test. Couldn't make it

Development related changes

  • Enable wallet testing on devnet.
  • Revert to es2016 in tsconfig.json (es2020 was never a part of an official plugin release, but happened in a commit between the latest release and this commit).
  • Introduce copyWithBigint which basically takes an already existing functionality and wraps it into a function. The function is now used in one more place.
  • Make Account methods protected.
  • Unfortunately some hackiness is introduced in multiInteract in account.ts, if the reviewer should find a better way of dealing with it
  • Refactor InteractChoice making it a class with methods and properties - pushes some logic directly into InteractChoice instead of having to write ifs and elses in various places.

Checklist:

  • I have formatted the code
  • I have performed a self-review of the code
  • I have rebased to the base branch
  • I have documented the changes
  • I have updated the tests
  • I have created a PR to the plugin branch of starknet-hardhat-example.

README.md Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@FabijanC FabijanC merged commit c092805 into master Mar 28, 2022
@FabijanC FabijanC deleted the invoke-options branch March 28, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants