Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable normal fee estimation on Devnet #96

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Enable normal fee estimation on Devnet #96

merged 3 commits into from
Apr 21, 2022

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Apr 21, 2022 •
edited

Usage related changes

  • No need for passing transactionVersion as a part of fee estimation options.

Development related changes

  • Bring back account testing on devnet.
  • Use starknet-devnet v0.1.23 for testing.
  • Set EstimateFeeOptions to be the same as CallOptions again.

Checklist:

  • I have formatted the code
  • I have performed a self-review of the code
  • I have rebased to the base branch
  • I have documented the changes
  • I have updated the tests
  • I didn't create a PR to the plugin branch of starknet-hardhat-example because I didn't need to.

@FabijanC FabijanC changed the title Enable fee estimation on Devnet Enable normal fee estimation on Devnet Apr 21, 2022
@FabijanC FabijanC merged commit 222dac3 into master Apr 21, 2022
@FabijanC FabijanC deleted the tx-version branch April 21, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badurinantun badurinantun badurinantun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FabijanC @badurinantun