Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve close mechanism #3

Closed
piranna opened this issue Dec 16, 2012 · 1 comment
Closed

Improve close mechanism #3

piranna opened this issue Dec 16, 2012 · 1 comment
Labels
bug

Comments

@piranna
Copy link
Member

piranna commented Dec 16, 2012

Thanks to the #2 pull request I've take a look to the specificacion and we are not following it both for closing DataChannels of PeerConnection since I don't give importance to it before. Since now this polyfill will focus on interoperation between native and websocket-based datachannels this is a requeriment to work correctly.
@piranna
Copy link
Member Author

piranna commented Dec 26, 2012

After reviewing, thank to the fixes on pull request #2 it seems it was according to the standard so only format fixing was required. Clossing.

@piranna piranna closed this as completed Dec 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@piranna