-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
tbh your wrap per sucks #1
Comments
forgot this: |
|
|
Why does the endpoint matter? Doesn't the error state where it was (such as get_band) |
it's easier to debug when you have the tag used that caused the error |
Does pep8 really matter when it's less characters and words? :/ Saying * is way easier than listing every single error |
pep8 always matters ;) |
fixed everything in here and your commit comments, if you find more issues, open another issue |
__str__
should be a method for player and band, etc 馃憤self.timeout = options.get('timeout')
should have a default of5
馃憤from .errors import *
should not be a wildcard import 馃憤what's the use of creating a var here 馃憤
8. why specify
camel_killer_box=True)
all the time? why not just create a box base class for your wrapper where you specify that in the init? 馃憤9.
get_player
should be alias forget_profile
馃憤10.
timeout: Optional[int] Quits requests to the API
should be**timeout
in docstrings 馃憤11. get the request code for unauthorized
401
? 馃thinkhope that's it12. in
__init__.py
:import utils isn't needed here? 馃憤
13. send only one message in the dpy cog example (readme.md) 馃憤
14. in all docstrings, for kwargs use
**varname
instead ofvarname
馃憤15.
Get your token by DMing Zihad#6591 on Discord or ask in the聽API Server.
update plox 馃憤The text was updated successfully, but these errors were encountered: