Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding Static #21

Closed
ASoleimaniB opened this issue Dec 11, 2018 · 2 comments
Closed

Embedding Static #21

ASoleimaniB opened this issue Dec 11, 2018 · 2 comments

Comments

@ASoleimaniB
Copy link

I thing the way this code implements Static Embedding is wrong. Am I right?
This code, uses x=variable(x) when wants to make the embedding static, while it should be something like: self.embed.weight.requires_grad=False

@skurzhanskyi
Copy link

Using Variable also works. You can check by yourself.

@Z-Jeff
Copy link

Z-Jeff commented Apr 29, 2020

It seems that the word embedding are kept static during training.
How to make the embedding changeable in backpropagation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants