Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining work for 5.0.0 netcore release for Umbraco 9 #381

Open
23 of 29 tasks
Shazwazza opened this issue Jan 19, 2022 · 22 comments
Open
23 of 29 tasks

Remaining work for 5.0.0 netcore release for Umbraco 9 #381

Shazwazza opened this issue Jan 19, 2022 · 22 comments
Milestone

Comments

@Shazwazza
Copy link
Owner

Shazwazza commented Jan 19, 2022

Remaining work to do for 5.0.0
TODO: This list is not complete!

  • Custom routes (see ArticulateRouter)
    • Tags + Categories
    • RSS for Tags/Categories
    • RSS + XSLT
    • Search
    • Markdown editor
    • Authors RSS
    • Meta weblog
    • Meta weblog Manifest
    • Rsd
    • Open search
    • Resetting routes when umbraco content changes
  • App_Plugins/Themes can be shipped but shouldn't be editable
    • For custom themes that are created in the back office, these should be created in the typical /Views/ folder probably under /Views/Articulate. The files in App_Plugins should be readonly.
  • Multi-target .net6 + .net7
  • BlobMl import/export
    • DisqusXmlExport.xml isn't saved (there is a TODO)
    • Exporting and importing with base64 images
  • Changing all media usages over to use new media picker and media gallery
  • Re-implement OutputCache commented out attributes

Known issues

  • The current documentation is out of date and should be synced with what is supported in v5
  • a-new Markdown editor for creating posts doesn't properly support images yet
  • UrlHelperExtensions.ArticulateAuthorRssUrl
  • Rendering the Tags or Categories ends up with RenderTagHtmlContentDateName line items, maybe this is only when date formatted slugs are used?
  • Surface controller forms rendered on virtual nodes (i.e. tags/categories) and using RedirectToCurrentUmbracoPage. Used to be done with VirtualNodeUrlProvider + ArticulateVirtualPage, but ArticulateVirtualPage is not used anymore, so needs testing and potentially fixing.
  • Tags/Categories RSS YSODs
  • BlobMl importer won't work for variants (known issue before this release)
  • BlobMl importer won't work for RTE with macros embedded (known issue before this release)
  • RSS feed listed in source under application/rss+xml is always for the root RSS even when rendering tags/category pages (which have their own RSS feeds) (known issue before this release)
@Shazwazza Shazwazza added this to the 5.0.0 milestone Jan 19, 2022
@michelletopp
Copy link

Hi Shaz, just checking how this is going. know you've been working on it when you can. :)

@vlinakis2
Copy link

Hi @Shazwazza,

I was wondering if you are progressing with the V9 or V10 implementation.

Best regards,
Vasilis

@Shazwazza
Copy link
Owner Author

I haven't had much time to look into this, I would love the community to provide some assistance if possible.

@warrenbuckley
Copy link
Contributor

@Shazwazza RSS for Tags/Categories in the Router is already done

@Shazwazza
Copy link
Owner Author

@warrenbuckley awesome, have marked above

@warrenbuckley
Copy link
Contributor

@Shazwazza this also seems to be done already

UrlHelperExtensions.ArticulateAuthorRssUrl

@warrenbuckley
Copy link
Contributor

@Shazwazza Just a few more items that have been fixed by PRs that are not checked off in this list

Tags/Categories RSS YSODs - Fixed in #397

Rendering the Tags or Categories ends up with RenderTagHtmlContentDateName line items, maybe this is only when date formatted slugs are used? - Fixed in #390

@warrenbuckley
Copy link
Contributor

Have a pending PR #403 for

Resetting routes when umbraco content changes

@DasMergo
Copy link

DasMergo commented Aug 10, 2022

@Shazwazza Is there a timeline when Articulate will be available for Umbraco 10? Thanks!?

@Shazwazza
Copy link
Owner Author

No timeline, this is a community effort right now. Warren has been making great progress but there's still more work to go and then testing and then beta and rtm.

@ssplyuvrajsingh
Copy link

Hi @Shazwazza, Now this package, is available for Umbraco V10 or V11?

@OwainWilliams
Copy link
Contributor

Hey @Shazwazza
Was going to have a look at "Rendering the Tags or Categories ends up with RenderTagHtmlContentDateName line items, maybe this is only when date formatted slugs are used?" but I was wondering if there was any more info about this? I enabled date formated slugs and couldn't see anything obvious to do with tags etc.
Thanks.

@Shazwazza
Copy link
Owner Author

@OwainWilliams hrm, sorry it's been a long time, I 'think' this is referring to rendering tags/categories actually outputs the text: "RenderTagHtmlContentDateName" instead of the actual tags/categories. I can't remember if this is when rendering the tags/categories pages (i.e. https://shazwazza.com/categories) or not. There's also potential, that maybe this is fixed. Sorry, i guess this just needs some investigation.

@OwainWilliams
Copy link
Contributor

@Shazwazza I guess even just investigating the issue and getting it ticked off as fixed is a help?

I'll look at this tomorrow.

@Shazwazza
Copy link
Owner Author

Absolutely :)

@OwainWilliams
Copy link
Contributor

  • Rendering the Tags or Categories ends up with RenderTagHtmlContentDateName line items, maybe this is only when date formatted slugs are used?

I've had a look around a few places and rendered tags and categories where they weren't already showing (e.g. homepage) and tags and categories render without any issues. I'd say this has been fixed

image

@OwainWilliams
Copy link
Contributor

  • a-new Markdown editor for creating posts doesn't properly support images yet

Not sure what else is expected from the markdown editor but I selected an image from the backoffice and it rendered with no issues on the front end.

image image

@Shazwazza
Copy link
Owner Author

@OwainWilliams the MD editor in question is the front-end /a-new path that is used to create blog posts, see https://github.com/Shazwazza/Articulate/wiki/Creating-a-blog-post#using-markdown-from-your-browser-works-great-with-mobile-phones-too

@Shazwazza
Copy link
Owner Author

@OwainWilliams ok lets mark the tag/category item as resolved, thanks!

@Shazwazza
Copy link
Owner Author

@OwainWilliams also for the "BlobMl importer ..." items, we don't need to worry about this since its a known issue in past releases. These should be converted to bugs if they aren't already.

@OwainWilliams
Copy link
Contributor

@OwainWilliams also for the "BlobMl importer ..." items, we don't need to worry about this since its a known issue in past releases. These should be converted to bugs if they aren't already.

I can check and I'll raise bugs if needed.

@Shazwazza
Copy link
Owner Author

@OwainWilliams I've also added another bullet point above - the Articulate docs are slightly out of date compared to what is available in v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants