Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to preserve important comment? #35

Open
686d7066 opened this issue Jun 12, 2014 · 2 comments
Open

Possibility to preserve important comment? #35

686d7066 opened this issue Jun 12, 2014 · 2 comments

Comments

@686d7066
Copy link

Hi,

I am currently working with Umbraco 7 and since this comes pre-configured with the Client Dependency framework it was natural to use this for bundling and minifiying javascript files.
However, in contrast to other minifiers I´ve worked with, DP removes comments marked as important with an exclamation mark.
For example the license information for jQuery:
/*! jQuery v1.11.0 | (c) 2005, 2014 jQuery Foundation, Inc. | jquery.org/license */

Comments of this type are most of the time copyright and license information and these have to be included when using such plugins in production.

I havent found a way to preserve such comments with DP. Did I miss a config-value or is this not possible?

@Shazwazza
Copy link
Owner

Hi, I can create an option for this, currently there is no option to enable this.

@Shazwazza
Copy link
Owner

Because CDF works at runtime you would not be shipping the CDF minified content in your source code which is where the copyright information would live, I don't think there's a legal requirement to keep these comments in the code that is served over http for your website (though I could be wrong). In any case, I can enable this in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants