Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode for SheCodeAfrica-Nairobi-Website #30

Closed
zidanegimiga opened this issue Jul 7, 2022 · 12 comments
Closed

Dark mode for SheCodeAfrica-Nairobi-Website #30

zidanegimiga opened this issue Jul 7, 2022 · 12 comments
Labels
enhancement New feature or request help wanted Extra attention is needed OSCA-Nairobi oss-kenya

Comments

@zidanegimiga
Copy link

zidanegimiga commented Jul 7, 2022

Hello! I'm suggesting that we add a dark mode for the website. Here's a modification I made using Figma. I'm requesting editing access if you like this.
Link to prototype

she-code-dark-mode-conribution (1)

image

@katungi
Copy link
Collaborator

katungi commented Jul 7, 2022

This is a really great initiative. Love it!!
@M-Tee, can you check this out??

@M-Tee
Copy link

M-Tee commented Jul 8, 2022

This is pretty cool. Love it.

@M-Tee
Copy link

M-Tee commented Jul 8, 2022

@zidanegimiga I can't find your email on Github. Could you share it

@zidanegimiga
Copy link
Author

@zidanegimiga I can't find your email on Github. Could you share it

Sorry about that, it's zidanegimigatemp@gmail.com

@M-Tee
Copy link

M-Tee commented Jul 9, 2022

@zidanegimiga I've sent an edit invite to the Figma file you can copy and paste dark mode.

@bettttttttttt
Copy link

bettttttttttt commented Jul 15, 2022

@katungi
The site but done in Angular
https://ng-sca-nairobi.netlify.app

Dark mode for the site matches device theme for now i.e. if your device is set as light theme, the site will be light and vice versa

@katungi
Copy link
Collaborator

katungi commented Jul 18, 2022

Hey @bettttttttttt, I love what you did with Angular, if only our site was done in angular. Regardless, we could definitely do the same.
This is issue is up for grabs. The idea is to have a toggle button that allows one to choose either dark or light mode, but by default it goes with the user's device theme.

@katungi katungi added enhancement New feature or request help wanted Extra attention is needed OSCA-Nairobi oss-kenya labels Jul 18, 2022
@bettttttttttt
Copy link

@katungi I'm just doing it with Angular for fun.
Anyway, I've added a skeleton loader on the events page, and the search input on the same page has a dynamic placeholder which I think is cool!

@katungi
Copy link
Collaborator

katungi commented Jul 19, 2022

Wait, you did all those in angular still??

@bettttttttttt
Copy link

@katungi Yes, everything I'm doing is in Angular
I'll share the repo by the end of the day

@katungi
Copy link
Collaborator

katungi commented Jul 19, 2022

Cool, I will make sure to give you a shoutout for your amazing work @bettttttttttt 👏🏿👏🏿

@katungi
Copy link
Collaborator

katungi commented Jul 19, 2022

I will close this for now and re-create a new issue for this so it can be worked on by someone else.

@katungi katungi closed this as completed Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed OSCA-Nairobi oss-kenya
Projects
None yet
Development

No branches or pull requests

4 participants