Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the Banner component #4

Closed
katungi opened this issue Jun 13, 2022 · 11 comments
Closed

Create the Banner component #4

katungi opened this issue Jun 13, 2022 · 11 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed OSCA-Nairobi

Comments

@katungi
Copy link
Collaborator

katungi commented Jun 13, 2022

The banner component should live in the /component folder in the root directory.
This task might need more than one contributor so if you feel limited to work on it or might need help on it, make sure to reach out to the maintainers.

  • The banner component must match the designs as shown below
    banner

  • The second bit with the image should be responsive. If the user is on mobile, the image should disappear and just leave the text.

This task should take a short time as well, so that we can finish the first sprint with it.

In-case of any blockers, be sure to ping the maintainers.

@katungi katungi added enhancement New feature or request good first issue Good for newcomers OSCA-Nairobi help wanted Extra attention is needed labels Jun 13, 2022
@johnGachihi
Copy link
Contributor

I can work on this

@katungi
Copy link
Collaborator Author

katungi commented Jun 13, 2022

Sure thing @johnGachihi , Take a stab at it. How long do you think it will take?

@johnGachihi
Copy link
Contributor

I've already made good progress, so I should be able to submit something for review today

@alexmagwe
Copy link

I would like to make a suggestion to animate the "learn, grow, connect" header.

@steekam steekam mentioned this issue Jun 15, 2022
@katungi
Copy link
Collaborator Author

katungi commented Jun 16, 2022

Hey @alexmagwe , that's a really great idea. What animation do you suggest?
Could you maybe provide a sample ?

@alexmagwe
Copy link

alexmagwe commented Jun 16, 2022

@katungi i was thinking of a text typing animation with only one word of the phrase being shown at a time. Something like this https://youtu.be/m0o0QNpY9-0

@katungi
Copy link
Collaborator Author

katungi commented Jun 21, 2022

Hey @alexmagwe , I personally think it would look good. Don't know what @VeldaKiara and @3stherMueni think of the idea.

@VeldaKiara
Copy link

hey @alexmagwe and @katungi that's good a idea, I am on board

@essym19
Copy link
Member

essym19 commented Jun 21, 2022

@alexmagwe I think it would look amazing, go for it!!

@alexmagwe
Copy link

@katungi how do I proceed? Do i create a new issue or just make a pull request.

@katungi
Copy link
Collaborator Author

katungi commented Jun 22, 2022

Hey @alexmagwe yeah, create a new issue and ping me to assign you. So that we can move this discussion there.

@katungi katungi closed this as completed Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed OSCA-Nairobi
Projects
None yet
Development

No branches or pull requests

5 participants