Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counts not updating on frontend #14

Closed
hereliesvince opened this issue Jan 4, 2018 · 4 comments
Closed

Counts not updating on frontend #14

hereliesvince opened this issue Jan 4, 2018 · 4 comments
Assignees
Labels

Comments

@hereliesvince
Copy link
Collaborator

Neither the counts, or email icon are displaying on the Frontend currently.

Backend
screenshot 2018-01-03 20 28 42_preview

Frontend
screenshot 2018-01-03 20 30 50_preview

@Shelob9
Copy link
Owner

Shelob9 commented Jan 4, 2018

The library we're using doesn't expose Twitter counts. Pretty sure that's an API limitation. No way to fix that.

Email not showing in front-end, probably either the showEmail Gutenberg attribute not saving right or the initialization script for front end doesn't parse it from saved atts to props for the shareview component properly.

@Shelob9
Copy link
Owner

Shelob9 commented Jan 4, 2018

Most likely issue is in this conditional here https://github.com/Shelob9/blockswp-share-block/blob/master/front-end.js#L17

@easilyamused
Copy link
Collaborator

easilyamused commented Jan 4, 2018

We know some networks no longer share their share counts.

Spent about 4 hours tonight working on this and found a handful of problems. Could not get the plugin to work locally or on pantheon. Worked on fixing the errors from the other ticket, but it seemed to make things worse.

Did discover that hiding the icons does not render on the font-end nor are the counts changing anymore.

On my local only 2 of the networks showed up because I had a older version (the release from master) When I installed the newer one(after complying) all the new styles worked but still only 2 networks. Worried the old settings are getting stuck in WP.

To be clear, we had a lot of issues tonight and we would start over with fresh code from master when trying different local setups and dev environments to make sure it was not on our ends.

We did run the build scrips, Vincent tried it too on Pantheon with same issues of counts not changing or settings rendering on the front-end.

@easilyamused easilyamused changed the title Counts/Email not displaying on frontend Counts not updating on frontend Jan 4, 2018
@Shelob9 Shelob9 closed this as completed in 7816853 Jan 5, 2018
@Shelob9
Copy link
Owner

Shelob9 commented Jan 5, 2018

Close via 7816853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants