Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with forge 33.0.59 #262

Closed
ghost opened this issue Sep 10, 2020 · 6 comments
Closed

Crash with forge 33.0.59 #262

ghost opened this issue Sep 10, 2020 · 6 comments

Comments

@ghost
Copy link

ghost commented Sep 10, 2020

shetiphiancore-1.16-3.8.1.jar
Forge 33.0.59
Minecraft 1.16.2

When adding this mod to my modpack the game hard crashes with "Exit Code 0"
The only log I have is latest.log

I only have 12 mods (10 not including EnderTanks/EnderChests), and they all load when shetiphiancore is removed

Running forge with just ShetiphianCore and EnderTanks/Chests works fine tho - So Im not sure whats happening

Mods im using:
aiotbotania-1.16.2-1.3.1
Botania-1.16.2-406
curios-forge-1.16.2-4.0.0.1
gardenofglass-1.5
jei-1.16.2-7.3.2.25
Patchouli-1.16-42
refinedstorage-1.9.5
refinedstorageaddons-0.7.1
StorageDrawers-1.16.2-8.1.0

@ShetiPhian
Copy link
Owner

ShetiPhian commented Sep 10, 2020

I don't know either.

Its a Mixin crash, but I don't use mixin, Vazkii does for the asm in Botania and Patchouli.
My guess is its a conflict with their mixin asm, and my asm that uses the java script one provided by Forge.
But even if that was confirmed to be the case I still wouldn't know if its something I could solve.

I'll upload my asm files here, maybe someone more versed in them can see the issue and offer a fix.

https://github.com/ShetiPhian/Localizations-and-Issues/tree/master/asm_coremods
(now that I've noticed that I misspelled the one file name it bugs me, but at the same time its just a file name and makes no difference so I'm not going to bother to change it)

@ShetiPhian
Copy link
Owner

Another thought, the asm in ShetiPhianCore can safely be disabled. I believe there is a command line flag in Forge to do this, just haven't found it yet.

@son0fether
Copy link

I confirm this is still a problem for the following:
Minecraft: 1.16.2
Forge: 33.0.61

Minimal repro case (fresh profile in Twitch, add fresh versions of these mods):
Mods:
| Botania | Vazkii | Botania-1.16.2-406.jar |  
  | Curios API (Forge) | TheIllusiveC4 | curios-forge-1.16.2-4.0.0.1.jar |  
  | EnderChests | ShetiPhian | enderchests-1.16-1.7.2.jar |  
  | EnderTanks | ShetiPhian | endertanks-1.16-1.9.2.jar |  
  | Patchouli | Vazkii | Patchouli-1.16-42.jar |  
  | ShetiPhianCore | ShetiPhian | shetiphiancore-1.16-3.8.1.jar |

Results in the "Re-entrance detected..." crash.

@ShetiPhian
Copy link
Owner

Just tested an idea.
I dropped back to Forge 33.0.23 and it works
So something Forge changed between 23 and 59 broke compatibility between their system and Mixin

@ShetiPhian
Copy link
Owner

Up to 33.0.34 works
33.0.35 Crashed: ClassCastException
33.0.36 and 33.0.37 work
33.0.40 Crashed: MixinInitialisationError
33.0.41 Crashed: ReEntrantTransformerError: Re-entrance error

33.0.37 Is the last build Forge Javascript asm is compatible with Mixin asm.

@ShetiPhian
Copy link
Owner

Here is a workaround build of my core.
https://www.curseforge.com/minecraft/mc-mods/shetiphiancore/files/3054960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants