Fix QodotMap builds outside of scene tree & optional blocking builds #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scene tree isn't available when QodotMap is instantiated outside of a scene tree. In this case, don't yield at all; this has the side effect of blocking until the build is finished.
When enabled, QodotMap will block until the map has finished building. This helps when building small maps where Godot might otherwise spend a lot of time idle between build steps for a single map.
Matoking
force-pushed
the
yield_without_scene_tree
branch
from
bf929ec
to
4f10360
Compare
Matoking
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scene tree isn't available when QodotMap is instantiated outside of a scene tree. In this case, use
Engine.get_main_loop()to yield control to the engine to keep the editor responsive while building the map.Using
Engine.get_main_loop()in every scenario (even when the scene tree is available) causes the editor to crash. Using it as a fallback does not seem to have any problems, though.