Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch rule files automatically #180

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Patch rule files automatically #180

merged 3 commits into from
Apr 3, 2023

Conversation

Shinigami92
Copy link
Collaborator

@Shinigami92 Shinigami92 commented Apr 2, 2023

Running pnpm run generate:rules results in some files that are invalid
We can run git diff -R src/rules/<plugin>/<rule>.d.ts > scripts/generate-rule-files/diffs/rules/<plugin>/<rule>.d.ts.diff to generate a diff file that reverts what is invalid

@Shinigami92 Shinigami92 added the enhancement New feature or request label Apr 2, 2023
@Shinigami92 Shinigami92 self-assigned this Apr 2, 2023
@Shinigami92
Copy link
Collaborator Author

@Dimava and @Julien-R44 please review this PR and give me some feedback
When this is merged, we can go back to #177 🙂

@Julien-R44
Copy link
Collaborator

LGTM ! Much simpler than my over-engineered system with ASTs ahah 🤪

Do we agree that we can now close #142 ?

@Dimava
Copy link
Contributor

Dimava commented Apr 2, 2023

@Shinigami92 LGTM

What happens if diff is not appliable?

BTW, would adding EventEmitter be a good idea for streamlining logging, counting and #137 ?

@Dimava
Copy link
Contributor

Dimava commented Apr 2, 2023

@Shinigami92 please add fixes for #181

@Shinigami92
Copy link
Collaborator Author

@Shinigami92 please add fixes for #181

Will do in separate PR 👍

@Shinigami92
Copy link
Collaborator Author

What happens if diff is not appliable?

I have not checked that, but I assume it would fail or something like that
Theoretically it is the same mechanism as https://www.npmjs.com/package/patch-package is doing

BTW, would adding EventEmitter be a good idea for streamlining logging, counting and #137 ?

Could you explain a bit more? Maybe outsource this discussion into a new separate issue/discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants