-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: async plugin importing #182
Conversation
Do I understand correctly that this will just parallelize the imports of the plugins? |
The only difference is that plugins get imported just before usage (in a function that alreaty was async), as the first (logged) step of plugin rule generation |
The code took around 90 seconds to start (for just |
@Julien-R44 I rewrote it a bit to apply more with "my" style I think the ES2020 is okay, as it does not affect the npm package code (see my other comment) Please leave your approval as well (if you do not have any further complains) and then I will merge |
Yes I was talking about the use of the ESM internally, not in the final "bundle" for end-users. But it doesn't seem to be a problem so that's cool! |
I got bored of generating one plugin taking minutes to start and made this