Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package detection #4

Closed
fare opened this issue Mar 23, 2017 · 6 comments
Closed

Package detection #4

fare opened this issue Mar 23, 2017 · 6 comments

Comments

@fare
Copy link

fare commented Mar 23, 2017

Couldn't you use a (defmethod perform :after ((o prepare-op) (s system)) ...) and a (defmethod perform ((o load-op) (s system)) ...) to record all the packages in existence before and after a system is loaded?

@Shinmera
Copy link
Owner

Possibly, but if I understand right, that would require the system to document be explicitly loaded after staple, yes?

@fare
Copy link
Author

fare commented Mar 23, 2017

Indeed.

@fare
Copy link
Author

fare commented Mar 24, 2017

Looks Good To Me. Congrats!

(Well, I think the way you store the intermediate results is a bit distasteful, but, oh well.)

@Shinmera
Copy link
Owner

I'm not happy with that either, to be honest. Any suggestions?

@fare
Copy link
Author

fare commented Mar 24, 2017

No great suggestions, except that there should probably be separate tables for "packages we know have been created by this system" and "packages known to exist before this system". Especially since, when you load a system twice, etc., you may want to add to the first, rather than overwrite it — or else, the second time will erase all the information.

@Shinmera
Copy link
Owner

Shinmera commented Mar 25, 2017

Ah, yeah, I hadn't thought of that case. Fixed it now, though it won't be able to detect the case where you add a package through C-c C-c or similar, so it's still not flawless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants