Surface grues not spawning with HC Darkness

[Laike-Endaril]

Description:

When using only Grue and Hardcore Darkness, surface grues do not appear in the overworld at night, when standing on the surface, in light level 0.

Affected versions:

• Minecraft: 1.12.2
• Forge: 14.23.5.2768
• Grue: 1.12.2-1.4.0
• Hardcore Darkness: 1.12.2-2.0

Latest log file for when the issue was present:

No relevant information in log file, but here it is anyway:
https://pastebin.com/fnN02HUm

[Shinoow]

Yeah, seems like Hardcore Darkness doesn't do anything with the sky light, so that stays at a steady 15 (had some logging running, and it jumped back and forth between 4 and 15). I guess ignoring skylight is the way to go here.

EDIT: the jumping between 4 and 15 is probably due to the logging not checking sides, so the server shows 4 while the client shows 15.

[Laike-Endaril]

Interesting...I'll do some debugging myself sometime since I have light levels being used in Dynamic Stealth as well (I need to make sure my own light levels are working correctly after all). Work is picking back up so it may be a day or two before I get around to it but I'll tell you my results when I get to it.

[Laike-Endaril]

Confirmed; HC Darkness does not reduce the sky light level outside to 0 on the server side, as you said. For some reason I thought it did, but it does not. Good news is that your mod, and my own mod, are both doing their light level checks correctly at least: lumien231/Hardcore-Darkness#38