Wind

[hinata235]

MMG model is changed to take wind force into account.

data.jl

• Added functions for ship superstructure data get_structure_params

mmg.jl

• Added wind_force_and_moment_ coefficients to calculate wind force and moments coefficients based on Fujiwara's formula (https://www.jstage.jst.go.jp/article/jjasnaoe/2/0/2_0_243/_article/-char/ja/).
• Add time-series data of wind speed and direction u_wind_list,ψ_wind_list to the arguments of existing functions.

ShipMMG.jl

• Changed due to changes in data.jl,mmg.jl

test_mmg.jl

• Changed due to the changes in data.jl,mmg.jl,ShipMMG.jl

Other changes

• Change Psi from uppercase to lowercase (Ψ→ψ)

[taiga4112]

Good code!! Thank you for your contributes.

In the viewpoint of minimum required functional modeling of MMG simulation, please modify your code as my review.

• Use Mmg3DofWindForceMomentParams instead of Mmg3DofStructureParams and organize where params are placed.

[taiga4112]

Various parameters need to be divided into the parameters needed for the simulation and the information to define them.

From your PR, I think that the following struct should be defined as essential information for MMG simulation.

@with_kw mutable struct Mmg3DofWindForceMomentParams{T}
    A_F::T
    A_L::T
    C_X_wind::T
    C_Y_wind::T
    C_N_wind::T
end

[hinata235]

Thank you for the comments!
It seems difficult to change Mmg3DofStructureParamstoMmg3DofWindForceMomentParams, because C_X_wind,C_Y_wind,C_N_wind are calculated sequentially using Mmg3DofStructureParams in mag_3dof_model!.
We need to have a discussion about this.

[taiga4112]

OK. I will show the example implementation of using Mmg3DofWindForceMomentParams in this branch.

[taiga4112]

@hinata235
Before my updating, please check and update the test code.
If the test code runs, some error occurred.

Following command shows the example for running test code.

julia > ] # package mode
(@v1.9) pkg> activate .
(ShipMMG) test 

[hinata235]

@taiga4112
I ran the above test code and no error occurred in my case.
Here is my operating environment.
It may be due to the difference in Julia's ver.

Julia> versioninfo()
Julia Version 1.8.2
Commit 36034abf260 (2022-09-29 15:21 UTC)
Platform Info:
OS: macOS (arm64-apple-darwin21.3.0)
CPU: 10 × Apple M1 Max
WORD_SIZE: 64
LIBM: libopenlibm
LLVM: libLLVM-13.0.1 (ORCJIT, apple-m1)
Threads: 1 on 8 virtual cores

[taiga4112]

I am not interested in your PC's execution environment.

Anyhow, I cannot find the Mmg3DofStructureParams params in the test code from your GitHub PR branch. Because of this reason, I can get the following error.

mmg.jl KVLCC2_L7 turning: Error During Test at /home/mitsuyuki/Dropbox/workspace/dev-ShipMMG/ShipMMG.jl/test/test_mmg.jl:3
  Got exception outside of a @test
  MethodError: no method matching mmg_3dof_simulate(::Mmg3DofBasicParams{Float64}, ::Mmg3DofManeuveringParams{Float64}, ::StepRangeLen{Float64, Base.TwicePrecision{Float64}, Base.TwicePrecision{Float64}, Int64}, ::Vector{Float64}, ::Vector{Float64}, ::Vector{Float64}, ::Float64; u0::Float64, v0::Float64, r0::Float64)
  
  Closest candidates are:
    mmg_3dof_simulate(::Mmg3DofBasicParams, ::Mmg3DofManeuveringParams, ::Mmg3DofStructureParams, ::Any, ::Any, ::Any, ::Any, ::Any; u0, v0, r0, x0, y0, ψ0, ρ, algorithm, reltol, abstol)
     @ ShipMMG ~/Dropbox/workspace/dev-ShipMMG/ShipMMG.jl/src/mmg.jl:543
  
  Stacktrace:
    [1] macro expansion
      @ ~/Dropbox/workspace/dev-ShipMMG/ShipMMG.jl/test/test_mmg.jl:16 [inlined]
    [2] macro expansion
      @ /opt/julias/julia-1.9.2/share/julia/stdlib/v1.9/Test/src/Test.jl:1498 [inlined]
    [3] top-level scope
      @ ~/Dropbox/workspace/dev-ShipMMG/ShipMMG.jl/test/test_mmg.jl:5
    [4] include(fname::String)
      @ Base.MainInclude ./client.jl:478
    [5] macro expansion
      @ ~/Dropbox/workspace/dev-ShipMMG/ShipMMG.jl/test/runtests.jl:9 [inlined]
    [6] macro expansion
      @ /opt/julias/julia-1.9.2/share/julia/stdlib/v1.9/Test/src/Test.jl:1498 [inlined]
    [7] top-level scope
      @ ~/Dropbox/workspace/dev-ShipMMG/ShipMMG.jl/test/runtests.jl:7
    [8] include(fname::String)
      @ Base.MainInclude ./client.jl:478
    [9] top-level scope
      @ none:6
   [10] eval
      @ ./boot.jl:370 [inlined]
   [11] exec_options(opts::Base.JLOptions)
      @ Base ./client.jl:280
   [12] _start()
      @ Base ./client.jl:522

Why can your test code run without error? It's quite strange for me...

[hinata235]

@taiga4112
It's my mistake. I had the wrong branch. I ran the test again on the correct branch and confirmed the same error.
I will modify test_mmg.jl and commit again.

[taiga4112]

#54

[taiga4112]

@hinata235
Still there are many errors after running your test code.
Please send PR before you check your code by running test code.

Following command is to run the test code of this repository.
#50 (comment)

[taiga4112]

@hinata235
This page shows the result of running your test code on GitHub server.

Please check it.

[taiga4112]

@hinata235
This PR is one of the implementation of Mmg3DofWindForceMomentParams instead of Mmg3DofStructureParams. Please check it.

The point of this PR is to separate between the definition of core parameters for calculating wind force & moment and the estimation method of this core parameters.