Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kepori Visual Overhaul #2892

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Kepori Visual Overhaul #2892

wants to merge 11 commits into from

Conversation

thgvr
Copy link
Member

@thgvr thgvr commented Apr 12, 2024

About The Pull Request

KEPORI.... TWO!!

PEGGLETWO

image

This PR aims mostly for parity with existing Kepori customization. A few customization options were removed as they didn't offer much. Also adds a new "Head Feathers" sprite accessory type so it's not tied to body, as well as cleaning up existing sprite accessories.

I believe this iteration of Kepori is closer to the original vision of what they should be, and was held back for various reasons during the past iteration. I've spent a long time on this, and I think it has come out very very well. Credits to spookypineapple for his great help during this process.

This doesn't include everything for now. I cut out some old jumpsuits that needed updating as I'd have to fully resprite them anyways. Some of them don't even have resprited human versions, so whatever.

TODO:

Literally everything else (not in this PR)

Changelog

🆑
imageadd: Kepori have been given a full visual overhaul.
/:cl:

@thgvr thgvr requested a review from a team as a code owner April 12, 2024 10:38
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Apr 12, 2024
@Sun-Soaked
Copy link
Contributor

this will be breast in 2027

@Anticept
Copy link
Contributor

Anticept commented Apr 12, 2024

Wear that is not aligned that I have found so far:

  • Undergarments
  • Engineer scanning goggles (actually seems to be goggles in general)
  • Breath masks
  • boot blood

@Slim-Pickems
Copy link

FBP are, naturally, a bit bugged at the moment. I do assume this is already in the works, but are logging it for the sake of logging it.
scuffed

@thgvr
Copy link
Member Author

thgvr commented Apr 13, 2024

Take note of my TODOs in the pr body

@thgvr
Copy link
Member Author

thgvr commented Apr 13, 2024

Blood overlays I have no idea how to set up framework for new ones, gotta think about it

@Anticept
Copy link
Contributor

Anticept commented Apr 13, 2024

Something also keeps moving my sprite down and right from time to time.
image

Rotation, such as going horizontal or *flip, is rotating around the far left side of the sprite for some reason.

@thgvr thgvr marked this pull request as draft April 16, 2024 01:52
@Redrover1760
Copy link

Kepori cursed one
Welding goggles
^ Welding goggles floating

Anyways outside the memes I love the new sprites. Voxified Kepori? Yes please.

@thgvr
Copy link
Member Author

thgvr commented May 6, 2024

prosthetics are now "good enough"

@thgvr
Copy link
Member Author

thgvr commented May 6, 2024

Probably go for underwear parity then call this done

Copy link
Contributor

github-actions bot commented May 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label May 9, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label May 9, 2024
@thgvr thgvr marked this pull request as ready for review May 14, 2024 12:54
@thgvr
Copy link
Member Author

thgvr commented May 14, 2024

It's "done"

@Anticept
Copy link
Contributor

Character appearance is missing the Character Adjective when kepori species is selected. Changing to another species is a workaround to get it to show and change it.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label May 20, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label May 22, 2024
@Anticept
Copy link
Contributor

Anticept commented May 22, 2024

All jumpsuits and outerwear is now broken (i_clothing and o_clothing slots) and are not loading kepori specific clothing.

In case it's relevant: rylie's fork as was affected too on sunday, and they still have oldkepori, so I wonder if something got pulled recently that is causing default human clothing to be used.

EDIT: Hoodies still work.

@FalloutFalcon
Copy link
Contributor

I bet its this pr.
https://github.com/shiptest-ss13/Shiptest/pull/2992/files#diff-88c50a053fb66bf3d7e6bc4fb8d91156017d286ba2a66f9f4e1872a7cbc0ef24
It had a bunch of stealth changes to species rendering and it never had a test merge.

@thgvr
Copy link
Member Author

thgvr commented May 22, 2024

lol

@thgvr thgvr marked this pull request as draft May 22, 2024 23:55
@Anticept
Copy link
Contributor

I bet its this pr. https://github.com/shiptest-ss13/Shiptest/pull/2992/files#diff-88c50a053fb66bf3d7e6bc4fb8d91156017d286ba2a66f9f4e1872a7cbc0ef24 It had a bunch of stealth changes to species rendering and it never had a test merge.

Good call. There's some commented kepori lines in there that states they should be uncommented with this PR.

@retlaw34 retlaw34 marked this pull request as ready for review May 24, 2024 23:38
@Anticept
Copy link
Contributor

Now hats and scarfs/collars are broken hahaha

image

@Slim-Pickems
Copy link

Slim-Pickems commented May 25, 2024

Inteq Uniforms and Belt slots are also now broken. I am checking to see any other broken uniforms.
Pictured, Inteq Corpsman preview (Talos Class)
image

Note, the vest now works.

@Anticept
Copy link
Contributor

Anticept commented May 25, 2024

Looks like the red beret specifically is broken. I'm looking through the recent changes and I noticed some logic was inverted. If someone doesnt beat me to this, I might take a whack at it.

Tailbags were also broken.

@Slim-Pickems
Copy link

image
Some shoes are also broken.
Shown is a preview of the Beluga's High Class Passenger.

@Slim-Pickems
Copy link

Looks like the red beret specifically is broken. I'm looking through the recent changes and I noticed some logic was inverted. If someone doesnt beat me to this, I might take a whack at it.

Tailbags were also broken.

It seems to be a lot more than the Red Beret, judging on previews in the character screen.

@thgvr thgvr marked this pull request as draft May 25, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants