Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a landing page for the server #4

Closed
Shivam010 opened this issue Aug 30, 2019 · 6 comments
Closed

Add a landing page for the server #4

Shivam010 opened this issue Aug 30, 2019 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs Label associated with the up-for-grabs.net

Comments

@Shivam010
Copy link
Owner

A landing page is required, as of now the server only works as an API.
The root path, / requests should route to the landing page and rest all request should be routed to use the current handler of the API.

Currently, https://non-cors.herokuapp.com/ returns StatusPreconditionFailed error

{
  "error": {
    "Code": 412,
    "Message": "URL not provided",
    "Detail": {
      "method": "GET",
      "requestedURL": "/"
    }
  }
}

but instead should be route to a landing page describing the bypass-cors server.

Suggestion: README.md file can be utilized to create the landing page.

@Shivam010 Shivam010 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers up-for-grabs Label associated with the up-for-grabs.net labels Aug 30, 2019
@Shivam010 Shivam010 self-assigned this Sep 1, 2019
@0xsubi
Copy link

0xsubi commented Sep 30, 2019

@Shivam010 I have kept it as small as possible.
#8

@Shivam010
Copy link
Owner Author

@sudhabindu1 Check the requested changes in the PR review.

@Shivam010 Shivam010 removed their assignment Jun 23, 2020
@vakhariaheet
Copy link

@Shivam010 Can I try it?

@Shivam010
Copy link
Owner Author

Shivam010 commented Sep 25, 2020

@heet-vakharia
Sure, you are most welcome.

Quick note: Try to utilize the README.md file

@vakhariaheet
Copy link

ok, Thank you

@Shub3am
Copy link

Shub3am commented Oct 2, 2022

is anyone working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs Label associated with the up-for-grabs.net
Projects
None yet
Development

No branches or pull requests

4 participants