Fix bug in repeated letter evaluation #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalfabik
changed the title
michalfabik
force-pushed
the
repeated-letters-revisited
branch
from
9db4ee6
to
21d2422
Compare
michalfabik
changed the title
michalfabik
changed the title
Likely fallout and/or oversight from ShivamPandya#9. Turning letters yellow wasn't working correctly in cases when the first repeated letter occured in the guess before its first occurrence in the correct answer and when the second occurrence in the guess was placed correctly. E.g. when guessing "LABEL" when the correct answer was "SKILL"
michalfabik
force-pushed
the
repeated-letters-revisited
branch
from
21d2422
to
90cf26f
Compare
michalfabik
changed the title
|
Hey, I am sorry it's taking longer for PRs to get merged. I was occupied with some work. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely fallout and/or oversight from
#9. Turning letters yellow
wasn't working correctly in cases when the first repeated letter occured
in the guess before its first occurrence in the correct answer and when
the second occurrence in the guess was placed correctly. E.g. when
guessing "LABEL" when the correct answer was "SKILL"