Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Asyncio] Test suite is failing #78

Closed
theunkn0wn1 opened this issue Jul 23, 2018 · 1 comment · Fixed by #168
Closed

[Asyncio] Test suite is failing #78

theunkn0wn1 opened this issue Jul 23, 2018 · 1 comment · Fixed by #168

Comments

@theunkn0wn1
Copy link
Collaborator

While investigating what it would take to enable 3.7 compatibility, I discovered the test suite is not currently in a passing state and, therefore, it is not possible to reliably prove any fix would take effect without introducing bugs / breaking behaviors.

This is very worrying, as my organization is building a IRC bot using this library that cannot blow up randomly do to an undetected bug in the underlying IRC infrastructure. As the tests are not passing, the stability of this project cannot be reliably proven. While Pydle appears to function as it is documented based on integration tests, It may prove difficult to both maintain the project and upgrade it without passing tests.

Environment:
Windows 10 x64, Linux
python x64 v 3.6.3 and 3.6.6

Test summery:

================================================= test session starts ==================================================
platform linux -- Python 3.6.6, pytest-3.6.3, py-1.5.4, pluggy-0.6.0
rootdir: /pydle, inifile: tox.ini
collected 53 items

tests/test__fixtures.py ...F                                                                                     [  7%]
tests/test__mocks.py FFF.........                                                                                [ 30%]
tests/test_client.py .FF.F.FFFFFF                                                                                [ 52%]
tests/test_client_channels.py ......                                                                             [ 64%]
tests/test_client_users.py ..............                                                                        [ 90%]
tests/test_featurize.py .....                                                                                    [100%]

Full error output: gist

looks like there is an issue somewhere in MockClient._connect, however I have been unable to narrow it down.

My apologies for wasting your time should this already be a known issue, for I am unable to find any reference to tests in recent issue tickets.

@shizmob
Copy link
Owner

shizmob commented Aug 5, 2018

Hmm, I'll take a look at this, thanks. :)

@theunkn0wn1 theunkn0wn1 self-assigned this Jan 1, 2019
Rixxan added a commit to Rixxan/pydle that referenced this issue May 6, 2022
Per Requests, removing the mock event loop. Pydle no longer rolls its own event loop, because Pydle is a good little program.
Rixxan added a commit to Rixxan/pydle that referenced this issue May 6, 2022
Rixxan added a commit to Rixxan/pydle that referenced this issue May 7, 2022
This segment was causing all sorts of "was not awaited" warnings, however removing it seems to have resolved these issues.

I think it's an artefact from when Pydle was running its own event loop.
Tests and Continuous Integration automation moved this from To do to Done Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants