Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop remaining libdislocator checks #1

Closed
Shnatsel opened this issue Aug 30, 2018 · 1 comment
Closed

Drop remaining libdislocator checks #1

Shnatsel opened this issue Aug 30, 2018 · 1 comment
Labels
good first issue Good for newcomers

Comments

@Shnatsel
Copy link
Owner

Shnatsel commented Aug 30, 2018

There are at least two superfluous checks this project has inherited from libdislocator:

  1. Additional protected page is allocated at the end of each region. This crashes the binary on buffer overflows, but uses more memory than normal.
  2. There is a global counter for the total amount of memory allocated, and at some point the library refuses to allocate any more. This is useful to detect a memory leak.

The primary reason I want to get rid of these is that I want to be sure that when a binary crashes under libdiffuzz and doesn't crash without it, it's because uninitialized memory is leaked into the output.

There are other excellent tools to isolate buffer overflows or memory leaks (asan, libdislocator), which should be used if those are the issues you're looking for.

@Shnatsel Shnatsel added the good first issue Good for newcomers label Aug 30, 2018
@Shnatsel
Copy link
Owner Author

Fixed by #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant