New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust 16mb minimum compression size for react-native-compressor@0.5.6 #57
Comments
+1 |
@emmbyiringiro @xuanhieupd today I am busy with office work. hope I will add this tomorrow. thanks |
Start from Expo SDK 42, the Expo team release a new service that makes the Expo app support a native module. Expo community has no built-i media compression package. This package is the one that is a great candidate as It has an easy setup and API to work with. I expect many Expo users to adopt this. I wish I can help more unfortunately I don't have a background in native development. You can read more about Expo native build here |
@emmbyiringiro @xuanhieupd can you check
|
Thanks for the patch. I have another issue or I'm doing wrong something. By default, the video size for compression is I was expecting this video to be compressed on to default of I guess that the logic should check if the size is less than or equal so provide compression size. I |
@emmbyiringiro can you confirm, in |
@emmbyiringiro can you send me the video, so I can check that video on my side? |
I investigate the issue and I found that all videos you want to compress must have a video size great than For example, if you have a video like this https://sample-videos.com/video123/mp4/360/big_buck_bunny_360p_1mb.mp4 which has width Even if video size In this situation, both video size and |
I installed but it crashed with I'm using Expo SDK 42 which uses React Native You can read more about this Expo Native module integration |
This issue happen on android |
@emmbyiringiro can you check
Add the Compressor plugin to your Expo config ( {
"name": "my app",
"plugins": ["react-native-compressor"]
} |
i will investigate this tonight |
Have tested this package with Expo 42. I tried and result in this error.
It seems that EXPO SDK 42 does not register native module |
@emmbyiringiro after the above steps, can you run these three commands and test them?
|
@emmbyiringiro closing this because I have fixed it and released the |
Some developers start to use this package within the expo. Unfortunately, Expo still uses an old version of React Native up to
React Native 0.64.3
.Can you remove this condition https://github.com/Shobbak/react-native-compressor/blob/dd5c106522461005acd89d6f679c0ef2f96fdd74/ios/Video/VideoCompressor.swift#L205
and old version users can benefit from that patch.
The text was updated successfully, but these errors were encountered: