Difference between UTC and local time causes CreditCard to appear as not expired

[ardelio]

We're currently experiencing an issue with credit card expiration that results from the difference between UTC time and current local time.

Referring to the code below, right now our local time is UTC+11. At 10:00:00AM (+1100), 1 April 2014, Time.now.utc returns 23:00:00 31 March 2014 UTC.

When the card expires in March 2014, expiration returns a time that is 23:59:59 31 March 2014 UTC.

A call to expired? thus returns false, however in local time, the card has expired (since we're now in April).

This seems like a bug that exists for the time difference between our local time and UTC time?

Our version: activemerchant (1.20.4)

Code

module ActiveMerchant
  module Billing
    class CreditCard
      class ExpiryDate #:nodoc:
...
        def expired? #:nodoc:
          Time.now.utc > expiration
        end

        def expiration #:nodoc:
          begin
            Time.utc(year, month, month_days, 23, 59, 59)
          rescue ArgumentError
            Time.at(0).utc
          end
        end
...
end

[ntalbott]

@asceresini I'm not sure that it's within ActiveMerchant's scope to try to nail expired exactly; when a card actually expires is probably time zone dependent and somewhat up to the issuer regardless. What trouble did this cause you?

[ntalbott]

I'm going to close this; it seems outside the scope of ActiveMerchant to nail the expiration time to the minute/hour.