paypal: fix dereference error in paypal_express_response #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling PaypalExpressResponse#address when the response didn't contain any address information was causing a dereference error: NoMethodError: undefined method `[]' for nil:NilClass Testing done: verified the dereference error doesn't happen by issuing a SetExpressCheckout API Operation with an invalid security header. Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
chengz
pushed a commit
to chengz/active_merchant
that referenced
this pull request
Dec 7, 2013
Calling PaypalExpressResponse#address when the response didn't contain any address information was causing a dereference error: NoMethodError: undefined method `[]' for nil:NilClass Closes activemerchant#628.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling PaypalExpressResponse#address when the response didn't contain
any address information was causing a dereference error:
NoMethodError: undefined method `[]' for nil:NilClass
Testing done: verified the dereference error doesn't happen
by issuing a SetExpressCheckout API Operation with an invalid
security header.
Signed-off-by: Pierre-Alexandre Meyer pierre@ning.com