Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser sniffer not properly parsing user agent for Chrome browser + Chrome OS #29

Closed
hurracrane opened this issue Apr 24, 2020 · 0 comments · Fixed by #30
Closed

Browser sniffer not properly parsing user agent for Chrome browser + Chrome OS #29

hurracrane opened this issue Apr 24, 2020 · 0 comments · Fixed by #30
Labels
bug

Comments

@hurracrane
Copy link
Contributor

When the user agent is Mozilla/5.0 (X11; CrOS x86_64 10066.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.122 Safari/537.36 for example the method BrowserSniffer#same_site_none_compatible? (here) returns false because the OS type is not parsed and returns nil. Though this combination of OS + browser should probably bed supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Chromium OS type in patterns Shopify/browser_sniffer
1 participant
@hurracrane