New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix development and live flag documentation for open theme open command #1035
Conversation
8af2208
to
77cfdc9
Compare
Hi @jeffreyguenther ! Thank you for your contribution :) Thanks again! |
77cfdc9
to
93d31d7
Compare
@isaacroldan Updated. Oh looks like I need to rebase. BRB |
These docs look to be from a different command. Let's change them to a version based on the docs live on shopify.dev.
93d31d7
to
797e2d8
Compare
@isaacroldan Rebase complete. Let me know if you need me to do anything else. |
Hi @jeffreyguenther, sorry to bother you again. We had an issue with some of our GH actions and PRs from forks, that should be fixed now. Could you rebase again please? |
No problem! @isaacroldan after syncing with upstream main, I'm seeing this error during my rebase:
I receive this error when I run Do you have suggestions on how to address? |
@isaacroldan I'm seeing this issue on |
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
@isaacroldan Given some time has passed, should these issues be fixed with a rebase? |
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
WHY are these changes introduced?
These docs look to be from a different command. Let's change them to a version based on the docs live on shopify.dev
WHAT is this pull request doing?
Fixes docs for:
shopify theme open -d
shopify theme open -l
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.