Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix development and live flag documentation for open theme open command #1035

Closed

Conversation

jeffreyguenther
Copy link

WHY are these changes introduced?

These docs look to be from a different command. Let's change them to a version based on the docs live on shopify.dev

WHAT is this pull request doing?

Fixes docs for:

  • shopify theme open -d
  • shopify theme open -l

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@isaacroldan
Copy link
Contributor

isaacroldan commented Jan 20, 2023

Hi @jeffreyguenther ! Thank you for your contribution :)
You'd need to run pnpm refresh-manifests to update the theme command manifest with the new descriptions.
Also, please run pnpm changeset add to add a (patch) changelog for this fix

Thanks again!

@jeffreyguenther
Copy link
Author

@isaacroldan Updated. Oh looks like I need to rebase. BRB

These docs look to be from a different command. Let's change them to a
version based on the docs live on shopify.dev.
@jeffreyguenther
Copy link
Author

@isaacroldan Rebase complete. Let me know if you need me to do anything else.

@isaacroldan
Copy link
Contributor

Hi @jeffreyguenther, sorry to bother you again. We had an issue with some of our GH actions and PRs from forks, that should be fixed now. Could you rebase again please?

@jeffreyguenther
Copy link
Author

jeffreyguenther commented Jan 25, 2023

No problem!

@isaacroldan after syncing with upstream main, I'm seeing this error during my rebase:

    ✖  nx run cli:refresh-manifests
       ›   Warning: oclif update available from 3.4.2 to 3.6.0.
           SyntaxError Plugin: @shopify/cli: The requested module '@shopify/cli-kit'
           does not provide an export named 'output'

        >  NX   ERROR: Something went wrong in run-commands - Command failed: pnpm oclif manifest

          Pass --verbose to see the stacktrace.

I receive this error when I run pnpm refresh-manifests to address the merge conflict. I ran pnpm install to make sure I have latest packages. Seems there's something going on in cli-kit.

Do you have suggestions on how to address?

@jeffreyguenther
Copy link
Author

@isaacroldan I'm seeing this issue on main when running pnpm refresh-manifest as well.

@github-actions
Copy link
Contributor

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

@jeffreyguenther
Copy link
Author

@isaacroldan Given some time has passed, should these issues be fixed with a rebase?

@github-actions
Copy link
Contributor

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants