-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: @oclif/core
dependency is duplicated when using NPM
#3506
Comments
Hi @frandiox ! You are right, i'm working on upgrading oclif dependencies but we are waiting for a new version of some of those packages with some changes we need. After that i'll update all of them :) |
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. P.S. You can learn more about why we stale issues here. |
Still relevant (I think?) -- @isaacroldan I see the version of |
I'll check it and make sure all plugins use the same version we do |
All oclif dependencies have been updated to use the same version of core |
Please confirm that you have:
In which of these areas are you experiencing a problem?
Other
Expected behavior
The
@oclif/core
dependency should be unique.Actual behavior
In latest versions, we can find both
@oclif/core@2
and@oclif/core@3
versions installed when using NPM.The
@oclif/core
dependency has been recently bumped to v3. However, the following dependencies in@shopify/cli
are still 1 version behind and they internally rely on v2, so it also gets installed:cli/packages/cli/package.json
Lines 98 to 100 in 44ada88
This is not a problem in this monorepo because PNPM is overwriting the
@oclif/core
version:cli/pnpm-lock.yaml
Line 10 in 44ada88
However, when using NPM to install
@shopify/cli@3.56.2
, we end up with the two versions installed.It looks like the following versions of the packages are aligned with
@oclif/core@3.15.1
:I've added this in Hydrogen to fix inconsistencies:
https://github.com/Shopify/hydrogen/blob/5c054f0bc09d73cab9d9977c035feac01e4b43a2/package.json#L94-L99
However, I'm not very familiar with the dependencies to know if we can bump them without creating other issues.
Reproduction steps
npm i
npm why @oclif/core
should show 2 versions installedOperating System
Mac latest
Shopify CLI version (check your project's
package.json
if you're not sure)3.56.2
Shell
zsh
Node version (run
node -v
if you're not sure)No response
What language and version are you using in your application?
No response
The text was updated successfully, but these errors were encountered: