[Bug]: --theme-editor-sync running infinite loop

[bigskillet]

Please confirm that you have:

• Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
• Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

Running shopify theme dev --store --theme-editor-sync should sync once on start.

Actual behavior

Sync gets stuck in an infinite loop:

Verbose output

Sorry, but --verbose runs in an infinite loop when combined with --theme-editor-sync. I'm not exactly sure what to paste here.

Reproduction steps

1. shopify theme dev --store --theme-editor-sync

Operating System

macOS Sonoma 14.5

Shopify CLI version

3.62.0

[dreamer-cloud]

+1, same issue after updating to 3.62.0

[agentfitz]

+1, same. Seeing infinite loops on settings_schema.json

Oddly, adding a trailing comma to the last item in our settings array in settings_schema.json seems to fix the issue 🤔 (found this clue on another thread)

@shopify/cli/3.59.3 darwin-arm64 node-v22.0.0

[stijns96]

Hi there 👋🏻

It probably has to due with the new trailing comma support. There are 2 solutions at the moment:

• Add a comma after the closing curly bracket
• Empty the file that is stuck in an infinite loop

This is always happening with the settings_schema.json . If you have this with another file, you most likely have an illegal unicode in your code.

[bdahlinger]

this got my Vite assets/manifest.json file too, same endless loop, trailing comma fixed :/

[JamiesonRoberts]

As a note, something really does need to be done about this, because most code editors these days do auto formatting of files, which does not support the trailing comma as its not part of the spec of JSON. This is causing a massive headache of having to manually copy files when making changes, rather than letting the CLI handle those changes

[karreiro]

👋 Hey everyone,

Thank you for your input and all the details about this issue. We've released a new version of the Shopify CLI some minutes ago with the fix (3.63.2). Please, if this problem persists, don't hesitate to reach out and share your --verbose output here.

Thanks again for reporting!

[lesterdefreitas]

Thanks @karreiro 👏🏻 You the man!

[lesterdefreitas]

Oh no... @karreiro

[karreiro]

Thank you for sharing that, @lesterdefreitas! I've also noticed a similar scenario here.

My original PR, unfortunately, missed a detail related to assets/* files. The fix for that is applied here, so we may expect that to be resolved in a new CLI release soon.

[lesterdefreitas]

Ah, awesome, thanks dude!

[DanielDanielsson]

Oh sweet baby jesus.. Thank you guys!