Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The add to cart button is getting a primary class if it's linked to a subscription #1540

Closed
ludoboludo opened this issue Mar 25, 2022 · 1 comment · Fixed by #1873
Closed
Assignees
Labels
Category: Bug Something isn't working

Comments

@ludoboludo
Copy link
Contributor

Describe the current behavior

The add to cart is receiving the button--primary class if the dynamic checkout is disabled or if there is a subscription option on that product.

Describe the expected behavior

Not sure if that should be the case 🤔 Shouldn't it get the outline class anyway as long as dynamic checkout is enabled?

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 4.0.0

Possible solution

remove the and part of this statement:

Additional context/screenshots
It can be seen/tested on this product:

@ludoboludo ludoboludo added the Category: Bug Something isn't working label Mar 25, 2022
@ludoboludo ludoboludo added this to To be triaged in Dawn: Iterations Roadmap via automation Mar 25, 2022
@LucasLacerdaUX LucasLacerdaUX mentioned this issue Mar 28, 2022
30 tasks
@nicklepine nicklepine moved this from To be triaged to Bugs Icebox 🐜 in Dawn: Iterations Roadmap Apr 8, 2022
@melissaperreault
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working
Development

Successfully merging a pull request may close this issue.

4 participants