We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the current behavior
The add to cart is receiving the button--primary class if the dynamic checkout is disabled or if there is a subscription option on that product.
button--primary
Describe the expected behavior
Not sure if that should be the case 🤔 Shouldn't it get the outline class anyway as long as dynamic checkout is enabled?
Version information (Dawn, browsers and operating systems)
Possible solution
remove the and part of this statement:
and
Additional context/screenshots It can be seen/tested on this product:
The text was updated successfully, but these errors were encountered:
Note: Seems to be related since https://github.com/Shopify/dawn-internal/pull/425/files#diff-f38ed67a42b1f5bee67cf7ed5873cf1839d3e83f21848da0c327078dffe47de0R550-R555
Sorry, something went wrong.
metamoni
Successfully merging a pull request may close this issue.
Describe the current behavior
The add to cart is receiving the
button--primary
class if the dynamic checkout is disabled or if there is a subscription option on that product.Describe the expected behavior
Not sure if that should be the case 🤔 Shouldn't it get the outline class anyway as long as dynamic checkout is enabled?
Version information (Dawn, browsers and operating systems)
Possible solution
remove the
and
part of this statement:Additional context/screenshots
It can be seen/tested on this product:
The text was updated successfully, but these errors were encountered: