Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filters] Filter pills clear svg UI has a hardcoded color #1590

Closed
melissaperreault opened this issue Apr 6, 2022 · 0 comments · Fixed by #1591
Closed

[Filters] Filter pills clear svg UI has a hardcoded color #1590

melissaperreault opened this issue Apr 6, 2022 · 0 comments · Fixed by #1591
Labels
Category: Enhancement New feature or request
Projects
Dawn: Iterations Roadmap

Comments

@melissaperreault
Copy link
Contributor

melissaperreault commented Apr 6, 2022 •
edited

Describe the current behavior

Filter pills clearing UI svg has an hardcoded color

Describe the expected behavior

It should use the --color-foreground like other patterns of clear or close on the theme.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 4.0

Possible solution

To test if we need to replace by

  • fill="none" or
  • fill="currentColor" or
  • removing completely the stroke="333030" mention
  • stroke="currentColor"
@melissaperreault melissaperreault added this to To be triaged in Dawn: Iterations Roadmap via automation Apr 6, 2022
@melissaperreault melissaperreault added the Category: Enhancement New feature or request label Apr 6, 2022
@melissaperreault melissaperreault mentioned this issue Apr 6, 2022
Merged
13 tasks
@nicklepine nicklepine moved this from To be triaged to Q2-C1-2022 in Dawn: Iterations Roadmap Apr 8, 2022
@nicklepine nicklepine moved this from Q2-C1-2022 to In progress in Dawn: Iterations Roadmap Apr 8, 2022
Dawn: Iterations Roadmap automation moved this from In progress to Done May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Enhancement New feature or request
Projects
Dawn: Iterations Roadmap
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update icon-small-close svg color settings association success Shopify/dawn
1 participant
@melissaperreault