Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDP: Allow user to escape modal / remove modal #168

Closed
bredowmax opened this issue Jul 12, 2021 · 1 comment
Closed

PDP: Allow user to escape modal / remove modal #168

bredowmax opened this issue Jul 12, 2021 · 1 comment

Comments

@bredowmax
Copy link
Contributor

bredowmax commented Jul 12, 2021

Problem
On the PDP, user can click on the image to enlarge it. If, however, the product image is very large (in my example, it is 3000 × 2999px), and if user is on a small screen (for example, on mobile), then this modal fills out the entire screen, and the only way to escape it is to find that white X button on the top right. If the image is on a white background, the user may not even understand that s/he is viewing an image right now.

Describe alternatives you've considered

  1. Add option to remove modal entirely. Many paid theme offer this option
  2. Let shopper click on the image on the opened modal to close it again. This would make it easier to escape the modal
  3. Don't open the modal with height:100vh but with width:100vw

Additional context/screenshots
Screenshot 2021-07-12 at 18 05 28

@melissaperreault
Copy link
Contributor

This is now possible with this change #1983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants