Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Desktop media position #1903

Closed
andrewetchen opened this issue Aug 8, 2022 · 0 comments · Fixed by #1766
Closed

[Bug] Desktop media position #1903

andrewetchen opened this issue Aug 8, 2022 · 0 comments · Fixed by #1766
Assignees
Labels
Category: Bug Something isn't working

Comments

@andrewetchen
Copy link
Contributor

Describe the current behavior

I noticed a small bug for the right media product__media-list while working on: #1766

This originated from #1720

When Desktop media position is set to right and the Desktop layout is set to Thumbnails or Thumbnail slider, the media list bottom margin is being set to 0 since it's the last "grid" element:

https://github.com/Shopify/dawn/pull/1110/files#diff-00b03bd62b155daa89082ba52094c182e46422a9e28cd3ec601b3a2291b52718

Screenshots

Desktop media position = Right, Desktop layout = Thumbnails

Desktop media position = Right, Desktop layout = Thumbnail carousel

Possible solution

Add the following to section-main-product.css

.product--right .product__media-list {
  margin-bottom: 2rem;
}

And make sure its margin-bottom: 0; when viewing quick add / choose options.

@andrewetchen andrewetchen added the Category: Bug Something isn't working label Aug 8, 2022
@andrewetchen andrewetchen self-assigned this Aug 8, 2022
@andrewetchen andrewetchen added this to To be triaged in Dawn: Iterations Roadmap via automation Aug 8, 2022
@andrewetchen andrewetchen moved this from To be triaged to In progress in Dawn: Iterations Roadmap Aug 8, 2022
@andrewetchen andrewetchen changed the title [Fix] Desktop media position [Bug] Desktop media position Aug 8, 2022
@andrewetchen andrewetchen moved this from In progress to In review in Dawn: Iterations Roadmap Aug 8, 2022
Dawn: Iterations Roadmap automation moved this from In review to Done Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working
Development

Successfully merging a pull request may close this issue.

1 participant