Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suboptimal image sizes in sections #1944

Closed
kmeleta opened this issue Sep 2, 2022 · 3 comments · Fixed by #2507
Closed

Suboptimal image sizes in sections #1944

kmeleta opened this issue Sep 2, 2022 · 3 comments · Fixed by #2507
Assignees
Labels
Category: Enhancement New feature or request

Comments

@kmeleta
Copy link
Contributor

kmeleta commented Sep 2, 2022

Describe the current behavior

Several sections are loading inappropriate image sizes (too high quality or too low quality) at certain breakpoints and configurations. These were noticed while testing #1906

Multicolumn - Desktop images load sizes appropriate for only a single visible column. In a > 2 column configuration, the images loaded are far larger than needed.

Collage - image block loading an image that's much larger than needed for the layout

Image banner, collapsible content - Mobile image not large enough, can appear blurry

Describe the expected behavior

Sections should ensure appropriate image sources are loaded according to the the section layout, viewport, and pixel density of the device.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 1.0.0
  • Chrome Version 91.0.4472.114
  • macOS Version 11.3.1

Possible solution

The logic in the sizes attribute should be tweaked to better support these conditions

Additional context/screenshots

These are just specific instances I noticed while testing certain sections, there are likely more.

@stufreen
Copy link
Contributor

stufreen commented Feb 22, 2023

@eugenekasimov
Copy link
Contributor

eugenekasimov commented Apr 10, 2023

@kmeleta I didn't notice any wrong sizes of images in the Image banner section 🤔.

Please, let me know if I miss something and you still see an issue there.

@kmeleta
Copy link
Contributor Author

kmeleta commented Apr 12, 2023

@eugenekasimov I tried a few image configurations and didn't notice any issues so some tweaks may have been added at some point. If you can't find any stand out issues either we can consider that one complete.

Dawn: Iterations Roadmap automation moved this from To be triaged to Done May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

3 participants