announcement bar x mobile drawer alignment #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lougoncharenko
requested review from
kjellr,
KaichenWang,
kmeleta and
stephanie-shopify
kjellr
reviewed
Jul 12, 2023
There was a problem hiding this comment.
This looks good on desktop, but on mobile it looks like the header is narrower than it was before. You can see it cut in here when you resize to a mobile breakpoint:
12-17-mpq30-v4vg7.mp4
I'm not sure we need this PR anymore though — on main, everything looks like it lines up ok:
12-21-cmgzg-4m1vj.mp4
|
@kjellr, the difference between this PR and main is the shopping cart icon is aligned with the currency and language pickers. But if that isn't important. we can scrap this PR. |
|
Ah, ok. Yes I think that's worthwhile. But I don't think we need the changes to |
stephanie-shopify
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
The hamburger menu drawer icon and cart icon on header are aligned with social icons and language/currency selectors on announcement bar
Why are these changes introduced?
Fixes #2748 .
What approach did you take?
Adding padding to the header and adding padding left to the locales
Visual impact on existing themes
Announcement bar and menu drawer will be aligned
Testing steps/scenarios
Demo links
Checklist