Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mega Menu L2 bold is being overwritten #2836

Closed
kimberlyoleiro opened this issue Jul 12, 2023 · 2 comments
Closed

Mega Menu L2 bold is being overwritten #2836

kimberlyoleiro opened this issue Jul 12, 2023 · 2 comments
Assignees
Labels

Comments

@kimberlyoleiro
Copy link

Small regression to #2644

Noticed a small regression in dawn/main for mega menu L2 styling - the bold is being overwritten by another css class
Screenshot 2023-07-12 at 2 55 13 PM

@lougoncharenko lougoncharenko self-assigned this Jul 13, 2023
@lougoncharenko
Copy link
Contributor

After investigating, the css behavior is to be expected. Because the shop all link being inspected above doesn't have any children(any level 3 links associated with it), the liquid code in the file assigns it to have a normal font weight. TO change the css on this class from normal to bold

Current:
.mega-menu__list--condensed .mega-menu__link {
font-weight: normal;
}

Change
.mega-menu__list--condensed .mega-menu__link {
font-weight: bold;
}
If we change it to font-weight bold, we get the following effect (see image below) where all the level 2 links are bold regardless of having any children or not.
Screenshot 2023-07-13 at 9 07 16 AM (2)

When I gave the shop all link some level 3 links (tote bags and shoulder bags), it bolded as expected (see images below)
Screenshot 2023-07-13 at 9 11 44 AM
Screenshot 2023-07-13 at 9 10 36 AM

TLDR: The behavior you're seeing on the demo store isn't a regression but typical behavior when the menu only has one level of links (only l2 and no l3) whereas the bolding occurs if the l2 has l3 links associated with it. To change the behavior would mean to change all of l2 links to be bold regardless if they have any l3 links.

@kimberlyoleiro
Copy link
Author

Oh, I see now! My brain registered Tote Bags and Shoulder Bags as nested below shop all. I'll close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants