Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Color Uses (Hardcoded colors) #441

Closed
2 tasks
nicklepine opened this issue Aug 19, 2021 · 0 comments · Fixed by #1591
Closed
2 tasks

Incorrect Color Uses (Hardcoded colors) #441

nicklepine opened this issue Aug 19, 2021 · 0 comments · Fixed by #1591
Labels
Category: Bug Something isn't working Severity: 3 Normal/Low Severity
Projects
Dawn: Iterations Roadmap

Comments

@nicklepine
Copy link

nicklepine commented Aug 19, 2021 •
edited

  • In the filter pills, the ‘X’ icon seems to have a hard coded color. It’s color should be pulled from the “Text color”

image

  • The filtering SVG icon has some white hardcoded color in it. The little circles should be transparent.

https://screenshot.click/18-06-is88g-5ik94.png
@nicklepine nicklepine added the Category: Bug Something isn't working label Aug 19, 2021
@nicklepine nicklepine added this to Severity: 2 Bugs 🐜 in Dawn: Iterations Roadmap Aug 19, 2021
@nicklepine nicklepine added the Severity: 2 High Severity label Aug 19, 2021
@nicklepine nicklepine moved this from Severity: 2 Bugs 🐜 to Severity: 3+ Bugs 🐜 in Dawn: Iterations Roadmap Aug 31, 2021
@nicklepine nicklepine added Severity: 3 Normal/Low Severity and removed Severity: 2 High Severity labels Jan 7, 2022
@nicklepine nicklepine moved this from Severity: 3 Bugs 🐜 to Bugs 🐜 in Dawn: Iterations Roadmap Feb 22, 2022
@melissaperreault melissaperreault mentioned this issue Apr 6, 2022
Merged
13 tasks
Dawn: Iterations Roadmap automation moved this from Bugs Icebox 🐜 to Done May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Bug Something isn't working Severity: 3 Normal/Low Severity
Projects
Dawn: Iterations Roadmap
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update icon-small-close svg color settings association success Shopify/dawn
1 participant
@nicklepine