Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for Polaris 10+ #46

Closed
mbaumbach opened this issue Sep 6, 2022 · 0 comments · Fixed by #48
Closed

[FEATURE] Add support for Polaris 10+ #46

mbaumbach opened this issue Sep 6, 2022 · 0 comments · Fixed by #48

Comments

@mbaumbach
Copy link

Feature request summary

We would like to see Polaris 10 added as a possible peer dependency for this project. E.g., in package.json:

"@shopify/polaris": "^9.7.0 || ^10.0.0",

There also appears to be a bug with the "react-dom" peerDependency. It currently has:

"react-dom": "^16.14.0 || ^17.0.0 || ^10.0.0"

I'm guessing that should be:

"react-dom": "^16.14.0 || ^17.0.0 || ^18.0.0"

Rationale

Trying to use these components in a project using Polaris 10+ fails due to peer dependency failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant