Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support rendering inline errors in MethodCard #91

Open
freemer opened this issue Aug 16, 2023 · 0 comments
Open

[FEATURE] Support rendering inline errors in MethodCard #91

freemer opened this issue Aug 16, 2023 · 0 comments

Comments

@freemer
Copy link

freemer commented Aug 16, 2023

Feature request summary

Currently duplicate title errors can only be rendered in a banner, as MethodCard has no inline error rendering capability - a potential solution would be to add an errors prop to the component.

Rationale

Without this feature, apps are unable to follow the app design alert guidelines.

Also

Where is the best place to report bugs? The discountAutomaticAppUpdate mutation currently returns doubles of the title must be unique error :D

{
    "data": {
        "discountAutomaticAppUpdate": {
            "userErrors": [
                {
                    "field": [
                        "automaticAppDiscount",
                        "title"
                    ],
                    "message": "must be unique",
                    "__typename": "DiscountUserError"
                },
                {
                    "field": [
                        "automaticAppDiscount",
                        "title"
                    ],
                    "message": "must be unique",
                    "__typename": "DiscountUserError"
                }
            ],
            "__typename": "DiscountAutomaticAppUpdatePayload"
        }
    },
   ...
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant