Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cart rework #311

Merged
merged 27 commits into from
Dec 13, 2022
Merged

Cart rework #311

merged 27 commits into from
Dec 13, 2022

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented Dec 7, 2022 •
edited
Loading

Changes

  • Move all cart routes back to demo-store
  • Remove optimistic UI

Updated doc: https://github.com/Shopify/h2/blob/hl-cart/rfc/cart.md
Optimistic UI demo: #318

@github-actions github-actions bot requested a deployment to preview December 7, 2022 18:48 Abandoned
@github-actions github-actions bot requested a deployment to preview December 7, 2022 19:10 Abandoned
@github-actions github-actions bot requested a deployment to preview December 7, 2022 20:09 Abandoned
@github-actions github-actions bot requested a deployment to preview December 7, 2022 20:44 Abandoned
@github-actions github-actions bot requested a deployment to preview December 8, 2022 17:40 Abandoned
@wizardlyhel wizardlyhel marked this pull request as ready for review December 8, 2022 19:16
@wizardlyhel wizardlyhel mentioned this pull request Dec 9, 2022
Closed
jplhomer
jplhomer reviewed Dec 9, 2022
View reviewed changes
Copy link
Contributor

@jplhomer jplhomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

rfc/cart.md Outdated Show resolved Hide resolved
rfc/cart.md Show resolved Hide resolved
rfc/cart.md Show resolved Hide resolved
templates/demo-store/app/routes/products/$productHandle.tsx Outdated Show resolved Hide resolved
templates/demo-store/app/data/index.ts Outdated Show resolved Hide resolved
rfc/cart.md Show resolved Hide resolved
cartogram
cartogram reviewed Dec 9, 2022
View reviewed changes
rfc/cart.md Outdated Show resolved Hide resolved
cartogram
cartogram reviewed Dec 9, 2022
View reviewed changes
rfc/cart.md Outdated Show resolved Hide resolved
blittle
blittle reviewed Dec 9, 2022
View reviewed changes
rfc/cart.md Outdated Show resolved Hide resolved
@github-actions github-actions bot had a problem deploying to preview December 13, 2022 15:07 Failure
jplhomer
jplhomer approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@jplhomer jplhomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good to merge this whenever we're ready.

@blittle blittle merged commit 7da6a73 into v0.x-2022-10 Dec 13, 2022
@blittle blittle deleted the hl-cart branch December 13, 2022 21:24
@github-actions github-actions bot mentioned this pull request Dec 13, 2022
Merged
@github-actions github-actions bot mentioned this pull request Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartogram cartogram cartogram left review comments

@benjaminsehl benjaminsehl benjaminsehl left review comments

@blittle blittle blittle left review comments

@jplhomer jplhomer jplhomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wizardlyhel @cartogram @jplhomer @benjaminsehl @blittle