Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart doesnt properly close when clicking the grey space to the left of it #1159

Closed
QuentinGibson opened this issue Jul 26, 2023 · 2 comments
Closed
Labels

Comments

@QuentinGibson
Copy link
Contributor

QuentinGibson commented Jul 26, 2023

What is the location of your example repository?

No response

Which package or tool is having this issue?

Other / I don't know

What version of that package or tool are you using?

Hydrogen Skeleton store

What version of Remix are you using?

1.17.1

Steps to Reproduce

Create a new store with these settings
image

Expected Behavior

When the darken area is clicked the cart should close
image

Actual Behavior

When the darken area is clicked the page is refreshed and the cart is still open

@QuentinGibson
Copy link
Contributor Author

QuentinGibson commented Jul 26, 2023

The error happens in Ubuntu Firefox 115. I tested it in chrome and it worked just fine.

Also, removing the line
window.location.hash = ''
fixed the issue with Firefox

@michenly michenly added the cart label May 2, 2024
@blittle
Copy link
Contributor

blittle commented Jun 21, 2024

Fixed in our new starter template, which no longer uses hash state opening and closing the cart, but uses react state instead.

@blittle blittle closed this as completed Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants