Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prune Cloudsql #279

Closed
ibawt opened this issue Apr 16, 2018 · 5 comments
Closed

prune Cloudsql #279

ibawt opened this issue Apr 16, 2018 · 5 comments

Comments

@ibawt
Copy link
Contributor

ibawt commented Apr 16, 2018

@KnVerey is there anything that's going to blow up if we remove cloudsql from the prune list? We've had a few issues due to dangling resources.

@KnVerey
Copy link
Contributor

KnVerey commented Apr 16, 2018

That isn't easy to do because

  • the whitelist would need to become dynamic based on whether or not cloudsql is actually available in the target cluster (this is part of the dynamic resource discovery work @stefanmb was doing in Runtime resource discovery #188); otherwise, the tool will cease to work against clusters that don't have that resource.
  • custom resources are currently deployed with create/replace, not apply. When we upgraded to 1.8, we ran into errors related to the fact that custom resources don't support strategic merge patching (and according to the documentation, this is still true). We don't currently support pruning anything that uses the replace strategy. It might work to batch them into the mass-apply after they've actually already been deployed, but it might not. Related: Use our own annotation to drive pruning #254

@ibawt
Copy link
Contributor Author

ibawt commented Apr 16, 2018

blech.

@ibawt
Copy link
Contributor Author

ibawt commented Apr 16, 2018

cc @mkobetic

@dturn
Copy link
Contributor

dturn commented Aug 8, 2018

as an update #312 has been merged. So the first bullet has been accomplished

@dturn
Copy link
Contributor

dturn commented Sep 26, 2018

The kubernetes-deploy side of this work has shipped.

@dturn dturn closed this as completed Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants