Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubernetes-run] Warn when pod is stuck pending #342

Open
KnVerey opened this issue Oct 9, 2018 · 1 comment
Open

[kubernetes-run] Warn when pod is stuck pending #342

KnVerey opened this issue Oct 9, 2018 · 1 comment
Labels
✨ enhancement Improvement or small feature

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Oct 9, 2018

Follow-up to #337

I think that if an unmanaged pod (from a task run or a deploy) has been pending for more than a certain number of seconds (30? 60?), we should emit a warning. We could also have the pod time out at that point, but I'm not really comfortable doing that based on the generic status of "Pending" alone. So logging a warning (which should include the pending reason) seems like a good place to start.

@ghost
Copy link

ghost commented Oct 10, 2018

This reminds me of a pattern I saw in Vertx, which has an event loop that you're not supposed to block for more than X seconds. If you do, you get repeated warnings and are meant to investigate.

https://vertx.io/docs/vertx-core/groovy/#golden_rule

Valuable takeaway perhaps is once the user sees the warning, investigates, and determines they can't reduce the time within the window, giving them some way to override the setting might be good. I've seen many people ask in the community about how to turn off the warning 😄

@KnVerey KnVerey added the ✨ enhancement Improvement or small feature label Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement Improvement or small feature
Projects
None yet
Development

No branches or pull requests

1 participant